Документ взят из кэша поисковой машины. Адрес оригинального документа : http://www.eso.org/projects/dfs/team/QA-code-review.html
Дата изменения: Fri Jul 29 16:50:21 2005
Дата индексирования: Sun Apr 13 22:48:59 2008
Кодировка:
Поисковые слова: arp 220

DFS Code Review organization

DFS Department
DFS code review process

HOME

INDEX

HELP

NEWS

DFS code review process

Internal code reviews may be organized within the DFS Department. Such review involves a limited number of persons (from 3 to 5), each reviewer also delivering at least 3 complete source "modules".
A "code module" is rather one or several source files (.c, .java, .for, .py, ...) corresponding to a consistent function: it can be, for example, a set of Java classes understandable in a "standalone way" (a reader should not need to have a complete overview of the application, or need to know about specific libraries such as Java swing, for instance).

The code review is marked out by 3 steps:

A kick-off meeting is organized by the DFS Department manager to:
- re-call main objectives and goals: a limited set of coding rules only are to be checked, using specific code review forms (Word document). These standard forms are to be filled in by each reviewer to give comments and a qualitative evaluation of each source module (one set of forms per source file). The set of coding rules to be checked is limited in order to have a common evaluation, whatever the coding language is or the application functionalities are. Anyway, a reviewer can add some additional rules, he thinks are important.
- how to proceed : perform cross-readings between reviewers: reviewer A delivers his own code which will be checked by reviewer B; B delivery is checked by reviewer C, ...
- present the expected schedule.
Source modules have to be delivered (as compressed tar file) and presented by each author/DFS component project manager at the kick-off meeting.
the code check itself . Each reviewer checks the code, and fill in standard code review forms (Word document). In principle, the check lasts about 2 weeks. Filled in code forms have to be sent to the DFS Department manager who will keep a copy and re-distribute them to the original author.
an acceptance meeting is then held to summarize main results and decide related actions.

The volume of code should correspond to the expected duration of the code check itself : usually at least a full day should be dedicated by each reviewer for code check. So, checking a single source file will certainly be insufficient to have a proper idea of the coding level, checking a complete library or application may require too much time.

DFS Department DFS code review process

DFS Department
DFS code review process